search

sandstorm-io / vagrant-spk

Packaging tool for Sandstorm, a self-hosting platform for web apps!
Apache License 2.0
55 stars 29 forks source link

Add missing .encode("UTF-8") calls. #308

Closed zenhack closed 2 years ago

zenhack commented 2 years ago

Apparently I am the first person to run vagrant-spk upgradevm since the Python 3 update. Without this, write() throws an exception complaining that we passed it a str instead of bytes.

ocdtrekkie commented 2 years ago

Hmmm, you also adjusted a line in setupvm, but what about the one on line 672 in upgradevm that's similar?

I know I tested setupvm, but upgradevm is indeed less frequently used.

zenhack commented 2 years ago

You're right, it's not necessary -- most likely I spotted it when skimming through, and assumed it needed the same fix, but it works just with the one change. I --aemnded it away.

I think it's needed for global-setup.sh because were opening it in binary mode? ('wb')