search

sandstorm / NeosTwoFactorAuthentication

Extend the Neos Backend Login with 2FA
MIT License
12 stars 8 forks source link

fix: Use correct action to submit second factor #19

Closed flammel closed 1 year ago

flammel commented 1 year ago

Hi,

thank you for open-sourcing this package! This PR fixes the form where the user enters their second factor. It currently uses action checkOtp in controller Login, but the action was recently renamed to checkSecondFactor (https://github.com/sandstorm/NeosTwoFactorAuthentication/blob/981446169a951948b637f9f13b2231e17d61e933/Classes/Controller/LoginController.php#L103). Currently (version 1.1.1), when the user enters their second factor and submits the form, they get redirected to the same form.

JamesAlias commented 1 year ago

Sry for taking so long. Thank you, this definitely slipped through.

The behavior seems to differ. On my machine the form action is empty, wich would be correct, as we are making a POST request to /neos/second-factor-login wich in turn routes to the checkSecondFactor action (see routing.yaml). That's why I didn't notice the bug.

Thanks again.