sandstorm / OptimizedRedisCacheBackend

Optimized Cache Backend for use as Neos Content Cache
6 stars 9 forks source link

BUG: Method signature incompability in Neos 5.1 #10

Closed gradinarufelix closed 4 years ago

gradinarufelix commented 4 years ago

I wanted to use this package in Neos 5.1/Flow 6.1 and got the following error:

PHP Fatal error: Declaration of Sandstorm\OptimizedRedisCacheBackend\OptimizedRedisCacheBackend::setDefaultLifetime(int $lifetime) must be compatible with Neos\Cache\Backend\AbstractBackend::setDefaultLifetime($defaultLifetime): void in /application/Packages/Application/Sandstorm.OptimizedRedisCacheBackend/Classes/OptimizedRedisCacheBackend.php on line 15

As far as I see, we just have to change the method signature and add the return type. I'll do that over the holidays and come up with a PR. Please merge it soon then :-)

skurfuerst commented 4 years ago

thanks <3 will do!