search

sandstorm / Sandstorm.CookiePunch

Neos Package for content-first consent management built on top of klaro.js.
MIT License
5 stars 3 forks source link

feature: Log blocked ressources #12

Open paavo opened 2 years ago

paavo commented 2 years ago

I'd love to see what ressources (script, iframe) were processed with replaceTags in Dev Log.

paavo commented 2 years ago

What about a PR integrating LoggerInterface?

JamesAlias commented 2 years ago

Hi @paavo, thanks for caring 🙂

Feel free to submit a PR 👍

A good place to start drafting a Solution would be https://github.com/sandstorm/Sandstorm.CookiePunch/blob/master/Classes/Eel/Helper/CookiePunch.php#L270

paavo commented 2 years ago

Thanks for the hint @JamesAlias

I think a setting what to log could make sense 🤔 Personally I'd like to only log (blocked Scripts / iFrames) for services not defined in settings. Does this make sense to you?

fheinze commented 2 years ago

Hey @paavo. Thx for your feedback on the package. We are always eager for more context.

  1. Do you want those logs in production because you allow your editors to place HTML NodeTypes and you want to see what they are placing that might need to be unblocked via a consent ...

  2. or is it more about development and integration and you want to see why elements do not show up because they have not been assigned to a service.

Cheers

paavo commented 2 years ago

Hi @fheinze We plan to use the Logs-Feature in development context too see if we missed assigning an integration to a service. I think about running a crawler to visit all sites and check the log after.

👋