search

sandstorm / Sandstorm.CookiePunch

Neos Package for content-first consent management built on top of klaro.js.
MIT License
5 stars 3 forks source link

Installing as per README leads to internal server error #18

Closed kdambekalns closed 1 year ago

kdambekalns commented 2 years ago

Following the README this is what I get after step 1:

Argument 1 passed to Sandstorm\CookiePunch\Eel\Helper\CookiePunchConfig_Original::filterServicesArrayByWhenCondition() must be of the type array, null given

The shipped settings lack an empty array as default:

Sandstorm:
  CookiePunch:
    consent:
      services: []
paavo commented 7 months ago

This "bugfix" created another Bug @kdambekalns & @JamesAlias 🙈 Setting default "empty" values is nasty and requires stricter composer orders. May we reset this change and check for Array or null in PHP?

Explanation: We have added CookiePunch Configuration to multiple packages like vendor/custompackage has their own Sandstorm.CookiePunch.consent.services.customServiceconfiguration.

Our custom/cookiepunch package requires sandstorm/cookiepunch and overrides this configuration again 😢