search

sandstormports / wordpress-sandstorm

WordPress Sandstorm package
Apache License 2.0
4 stars 3 forks source link

404s are not nice formatted #25

Open xet7 opened 6 years ago

xet7 commented 6 years ago

From @JamborJan on February 26, 2017 20:30

Usually templates offer nice formatted 404 error pages including the possebility to incude a search form etc. Unfortunately the sandstorm version doesn't have that.

I'm not quite at the point where I can nail down the root cause but I will try to find something.

@dwrensha can you maybe please add some intsruction to README.md so that I can make a build to test my changes?

What you get today when you open a not existing URL like mydomain.com/something/wrong: bildschirmfoto 2017-02-26 um 21 33 46

What you might want (example): bildschirmfoto 2017-02-26 um 21 30 43

Copied from original issue: dwrensha/wordpress-sandstorm#31

xet7 commented 6 years ago

From @dwrensha on March 6, 2017 23:25

Sandstorm does not currently provide a way for apps to specify custom 404 pages. In case you're curious, the code that servers the 404 right now is: https://github.com/sandstorm-io/sandstorm/blob/v0.204/shell/server/pre-meteor.js#L133-L145. In theory it would be possible to enhance Sandstorm's current hacky web publishing feature to allow custom 404 pages. The longer-term plan is to use the interfaces described in web-publishing.capnp. In particular, it describes a notion of "not-found entities": https://github.com/sandstorm-io/sandstorm/blob/v0.204/src/sandstorm/web-publishing.capnp#L77-L79.