sandulat / routes-gen

Framework agnostic routes typings generator. Remix ☑️ SolidStart ☑️
MIT License
283 stars 12 forks source link

add plugin @routes-gen/solid-start #29

Closed nirtamir2 closed 1 year ago

nirtamir2 commented 1 year ago

This PR adds a new plugin @routes-gen/solid-start. You can see it running and published under @nirtamir2/routes-gen-solid-start and play with it in https://github.com/nirtamir2/solid-start-starter/tree/routes-gen-published

Closes #28

sandulat commented 1 year ago

@nirtamir2 answered in https://github.com/sandulat/routes-gen/discussions/28.

nirtamir2 commented 1 year ago

@sandulat It's ready for review! 🎉

sandulat commented 1 year ago

@nirtamir2 Sorry for the delay, I need to find some time to test it, since I've never used Solid/Solid Start before.

nirtamir2 commented 1 year ago

@sandulat you can use https://github.com/nirtamir2/solid-start-starter/tree/routes-gen-published and replace my published package with the code you want, or just inline it like I've done in https://github.com/nirtamir2/solid-start-starter/tree/routes-gen

nirtamir2 commented 1 year ago

@sandulat Any update? Can I help somehow?

sandulat commented 1 year ago

@nirtamir2 At first glance, everything seems to be working. After doing the tiny fixes I've requested above, we can publish the package right away.

nirtamir2 commented 1 year ago

@sandulat Thanks! I fixed the issues

sandulat commented 1 year ago

Thank you so much @nirtamir2! <3