search

sandy9999 / WorkGen

WorkGen is a collaboration with TeachForIndia in an effort to use technology to aid teachers around the country by automating question paper generation
https://workgen.org
4 stars 5 forks source link

Format paper #12

Closed sandy9999 closed 5 years ago

sandy9999 commented 5 years ago

Basically just used this.

if (window.confirm('If you click "ok" you would be redirected . Cancel will load this website ')) { window.location.href='https://www.google.com/chrome/browser/index.html'; };

See if it's okay. It appears plain, it's just meant to be quick fix.

akspi commented 5 years ago

What does this PR do? What changes do they introduce? Why were those changes necessary? What problems do they fix? You're supposed to answer these questions rather than

Basically just used this.

if (window.confirm('If you click "ok" you would be redirected . Cancel will load this website ')) { window.location.href='https://www.google.com/chrome/browser/index.html'; };

See if it's okay. It appears plain, it's just meant to be quick fix.

I can see 3 commits all of which are poorly named with no real description of what they do.