sandydays / pe

0 stars 0 forks source link

Incorrect error message shown in command box #6

Open sandydays opened 4 years ago

sandydays commented 4 years ago

Summary: Error message claims command format is incorrect, when it is. Only the index number is wrong.

Steps to reproduce: submit 0

Expected results: States index is out of bounds.

Actual results: Command format is stated to be incorrect, but it is is correct, just that given index is wrong This issue is only for indices <= 0 As a result, inconsistent error messages for indices lower or higher than the expected range.

Screenshot of issue: image.png

nus-pe-bot commented 4 years ago

Team's Response

Rejected bug. The command usage message clearly states "Use submit with parameters:submit INDEX (positive integer) to submit the specified draft." As 0 is not a positive integer, an invalid command error ought to be thrown instead of an invalid index error. Severity downgraded from 'Medium' to 'Low' as the normal operation of the product remains unaffected as an error message is displayed and the invalid 'submit 0' command does not execute.

Capture.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue type

Team chose [type.FunctionalityBug]. Originally [type.FeatureFlaw].

Reason for disagreement: [replace this with your reason]