search

sandydoo / ember-google-maps

A friendly Ember addon for working with Google Maps.
https://ember-google-maps.sandydoo.me
MIT License
93 stars 24 forks source link

Maps in demo page do not work currently #164

Closed eelke closed 2 years ago

eelke commented 2 years ago

None of the maps on the demo site seem to work. Tested on Mac & iOS, on Firefox, Chrome and Safari.

I noticed you've switched to Embroider, as indicated by the chunk js and your issue to convert to v2 addon. I previously also tried compiling my app (which uses ember-google-maps) with Embroider, but it didn't work for me, and apparently here it's also causing issues. Maybe it's possible to keep the docs running on the old build system until everything works with Embroider?

Console throws a lot of errors:

10:18:57.024
Error while processing route: docs.map n(...).createTemplateFactory is not a function 1108@https://ember-google-maps.sandydoo.me/assets/chunk.54bd5ed159935144dda4.js:1:115
o@https://ember-google-maps.sandydoo.me/assets/chunk.54bd5ed159935144dda4.js:1:125946
9182/<@https://ember-google-maps.sandydoo.me/assets/chunk.54bd5ed159935144dda4.js:1:76850
o.prototype.exports@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:1:2169
requireModule@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:1:551
get@https://ember-google-maps.sandydoo.me/assets/chunk.5ee67cebb45480d8a0b2.js:2:179555
_extractDefaultExport@https://ember-google-maps.sandydoo.me/assets/chunk.5ee67cebb45480d8a0b2.js:2:184714
resolveOther@https://ember-google-maps.sandydoo.me/assets/chunk.5ee67cebb45480d8a0b2.js:2:179669
resolveTemplate@https://ember-google-maps.sandydoo.me/assets/chunk.5ee67cebb45480d8a0b2.js:2:182505
resolve@https://ember-google-maps.sandydoo.me/assets/chunk.5ee67cebb45480d8a0b2.js:2:181366
resolve/t<@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:7846
resolve@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:7952
resolve@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:8035
u@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:5352
l/<@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:4652
l@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:5253
lookup@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:3802
lookup@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:182765
r<@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:142956
[render]@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:143140
renderTemplate@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:143237
setup@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:141065
o@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:468339
routeEnteredOrUpdated@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:468423
setupContexts@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:467778
finalizeTransition@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:466644
getTransitionByIntent/r.promise<@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:465872
b@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:475343
g@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:475235
invoke@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:419214
flush@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:418274
flush@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:420056
_end@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:425143
end@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:422232
_run@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:425657
run@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:422778
d@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:275681
e@https://ember-google-maps.sandydoo.me/assets/vendor.549a67238afb5ee99985760ac7392aaf.js:11:234268
array.js:1772
10:18:57.026
Uncaught TypeError: n(...).createTemplateFactory is not a function
    Ember 38
chunk.54bd5ed159935144dda4.js:1:115
sandydoo commented 2 years ago

Thank you, @eelke! I’ve redeployed the docs.

Embroider has gotten much better lately. I use the doc app as a final embroider integration test for this addon because the dummy test app is far from a normal app and, therefore, completely unreliable. It’s actually prember that’s causing issues.