sandyk0105 / pe

0 stars 0 forks source link

Able to create a transaction with amount 0 #2

Open sandyk0105 opened 1 week ago

sandyk0105 commented 1 week ago

In a real world scenario, it does not make sense having a transaction of amount 0 (or -0), it must be a negative (outcome) or positive (income).

addt 7 d/hello amt/0 o/myselt dt/2024-12-12

image.png

There's no point of having this allowed. Hence, a feature flaw bug and Low severity (not cosmetic problem).

soc-se-bot commented 1 week ago

Team's Response

image.png

There is no harm in allowing a 0-valued transaction. There is harm in banning it (because it would diminish flexibility). 0-valued transactions are also useful as placeholder transactions for bookkeeping purposes as a financial consultant, too (in cases where you may not the balance displayed to take into account its value yet, but you still want it to be noted in the app).

It is possible that a transaction between two companies are recorded as net amount zero (e.g. partnership between two companies where they agree to exchange services without any net cash spending incurred). Hence, we allowed this following the principle of allowing flexibility for users.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]