sandysound / orvibo-b25-server

A server to control the Orvibo B25 smart sockets
Apache License 2.0
17 stars 8 forks source link

Implement web service + related changes #11

Closed JCotton1123 closed 6 years ago

JCotton1123 commented 6 years ago

This is an unfinished PR. I've opened it to see if you'd be open to accepting these changes and to discuss them.

The gist of this update is:

Here's a screenshot of the web UI:

screen shot 2018-03-18 at 3 21 36 pm

sandysound commented 6 years ago

Hey @JCotton1123 sure, aways happy to have some more input. I'll have a look through it in properly in the next couple of days.

JCotton1123 commented 6 years ago

@sandysound I've been back and forth about whether to move my changes into a new project. Initially I was thinking developing the REST API (sort of) would be a convenient way for most users to interface with the "server". But I think I agree that the API/web service should just be moved into its own project. I am going to close this PR and I'll open a new one with some of Orvibo.js specific changes. I'll review your code comments before opening the PR.