search

sanel / monroe

Clojure nREPL client for Emacs
161 stars 21 forks source link

Use .nrepl-port hint if available #22

Closed juergenhoetzel closed 7 years ago

juergenhoetzel commented 7 years ago

To avoid searching/entering the port manually (this is just a stripped down/simple version of the corresponding cider functionality)

Thanks for this nice package :+1:

technomancy commented 7 years ago

The when-let macro that you're using here comes from a library that is not listed in Monroe's dependencies; it would be better to replace it with separate when and let. Thanks.

juergenhoetzel commented 7 years ago

The when-let macro that you're using here comes from a library that is not listed in Monroe's dependencies; it would be better to replace it with separate when and let. Thanks.

Good Point. I amended the commit.

sanel commented 7 years ago

Thanks @juergenhoetzel for the patch and @technomancy for catching missing macro issue. Merged.