sanemat / do-not-merge-wip-for-github

Do Not Merge WIP for GitHub
MIT License
406 stars 32 forks source link

Action Required: Do Not Merge WIP for GitHub Requires Changes to Comply with Chrome Web Store Policy #333

Closed sanemat closed 1 year ago

sanemat commented 1 year ago

We wanted to let you know that your item is at risk of being removed from the Chrome Web Store. Please find the details below.

Item name: Do Not Merge WIP for GitHub

Item ID: nimelepbpejjlbmoobocpfnjhihnpked

Violation(s):

Use of Permissions:

Violation reference ID: Purple Potassium Violation: Requesting but not using the following permission(s): storage How to rectify: Remove the above permission(s) Relevant section of the program policy: Request access to the narrowest permissions necessary to implement your Product's features or services. Don't attempt to "future proof" your Product by requesting a permission that might benefit services or features that have not yet been implemented. (learn more)

Important information about resubmission:

Please make the necessary changes within 14 days in order to avoid removal.

sanemat commented 1 year ago

https://github.com/sanemat/do-not-merge-wip-for-github/blob/d01de90eb906d33b9cc2c83e87e0f3e1a8bc55c5/app/manifest.json#L10-L12

sanemat commented 1 year ago

we use it :thinking: https://github.com/sanemat/do-not-merge-wip-for-github/commit/83e26ca8acc022f07bf0486afce73ba85dc2e438

sanemat commented 1 year ago

https://developer.chrome.com/docs/webstore/troubleshooting/#misunderstood-perms-storage

storage

The storage permission exposes the chrome.storage API to the extension.

When is it required? When using the chrome.storage API. When is it NOT required? When using the Web Storage API (document.localStorage, document.sessionStorage) or IndexedDB.

sanemat commented 1 year ago

https://developer.chrome.com/docs/extensions/migrating/mv2-sunset/

sanemat commented 1 year ago

I submitted for review v2.0.3 :pray:

sanemat commented 1 year ago

v2.0.3 :tada: https://chrome.google.com/webstore/detail/do-not-merge-wip-for-gith/nimelepbpejjlbmoobocpfnjhihnpked