search

sanette / tsdl-image

OCaml SDL2_image bindings to go with Tsdl
https://sanette.github.io/tsdl-image/
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Use complete SONAME in dlopen #1

Closed Firobe closed 2 years ago

Firobe commented 3 years ago

Thanks for taking over the maintenance of these packages!

On my system (Manjaro), commit f70eabb7958500c46b951da52a1e4bf56cd00d9b broke runtime execution: the specified filename libSDL2_image-2.0.so does not exist. Indeed in my understanding the soname that is guaranteed to exist should be libSDL2_image-2.0.so.0 (as returned by objdump -p /usr/lib/libSDL2_image-2.0.so.0.2.3 | grep SONAME).

I do not have multiple systems to check that this assumption is true but this is what I gather from the usual shared object conventions.

NOTE: there is the same issue on tsdl-mixer and ttf. I'm not opening PRs there to avoid spamming but this should also be fixed eventually.

On a side note, where should potential issues be reported in the future? Currently you have not enabled Issues on this repo so I assume issues should still be reported at tokenrove's?

Firobe commented 3 years ago

Gentle reminder about this issue :) Currently the tsdl-* packages are broken for all distros following this convention.

sanette commented 2 years ago

sorry I didn't get any github notifications for this one and it got lost...

sanette commented 2 years ago

"Issues" are now enabled

sanette commented 2 years ago

Indeed in my understanding the soname that is guaranteed to exist should be libSDL2_image-2.0.so.0 (as returned by objdump -p /usr/lib/libSDL2_image-2.0.so.0.2.3 | grep SONAME).

I'm having the same here with objdump -p /usr/lib/x86_64-linux-gnu/libSDL2_image-2.0.so.0.2.3 | grep SONAME, so this sounds better indeed.

sanette commented 1 year ago

relevant issue: https://github.com/yallop/ocaml-ctypes/issues/304