search

sangcomz / FishBun

:blowfish:FishBun is Image Picker for android.
Apache License 2.0
671 stars 143 forks source link

Auto-select photo taken via camera. #144

Open acherkashyn opened 5 years ago

acherkashyn commented 5 years ago

Is your feature request related to a problem? Please describe. When I take a photo via Camera button, FishBun takes me back to the photo grid, but the photo I just took is not selected. This is odd as if I need to select photos from gallery and take some more with a camera, I expect that they will be selected. After all, if I don't want to use a photo, I would just tap "back" from the camera, and not take a photo, but since I took it, I actually do want to use it.

Describe the solution you'd like A FishBun builder option to automatically select photos taken via camera button, like autoSelectPhotosFromCamera(true) I actually believe that true should be the default, this seems intuitive.

Describe alternatives you've considered The alternative is to keep in mind that I actually need to do an extra step to tap select a photo I just took. in the grid.

Additional context I'm using FishBun indirectly as it is included in multi_image_picker flutter library.

sangcomz commented 5 years ago

If everything is selected, how does this method work? Have you thought of anything? @acherkashyn

Sh1d0w commented 5 years ago

@sangcomz I guess it should not let you take a picture if you reached the selection limit? Same as trying to select more photos when you have reached max images.

acherkashyn commented 5 years ago

@sangcomz What @Sh1d0w said. If the selection limit is reached, it should not select it. I think it should show the same "Selection full. Deselect an image to choose another" snackbar.

sangcomz commented 5 years ago

I see, i will update this feature

ThinkDigitalSoftware commented 5 years ago

Adding my support for this

ThinkDigitalSoftware commented 4 years ago

@sangcomz Hey, just checking to see if this will be added soon