sanger-tol / blobtoolkit

Nextflow pipeline for BlobToolKit for Sanger ToL production suite
https://pipelines.tol.sanger.ac.uk/blobtoolkit
MIT License
10 stars 0 forks source link

removed unused line to fix compilation error #29

Closed alxndrdiaz closed 1 year ago

alxndrdiaz commented 1 year ago

PR checklist

alxndrdiaz commented 1 year ago

If the unused line is not removed there is the following compilation error:

nextflow run main.nf -profile test,singularity
Module compilation error
- file : /nfs/users/nfs_a/ar34/blobtoolkit/./workflows/blobtoolkit.nf
- cause: Unexpected input: 'def' @ line 10, column 1.
   def summary_params = NfcoreSchema.paramsSummaryMap(workflow, params)
   ^

When the line is removed the error disappears:

executor >  local (6)
[29/5acc0c] process > NFCORE_BLOBTOOLKIT:BLOBTOOLKIT:INPUT_CHECK:INPUT_TOL (1)                       [100%] 1 of 1 ✔
[12/3c9813] process > NFCORE_BLOBTOOLKIT:BLOBTOOLKIT:INPUT_CHECK:SAMPLESHEET_CHECK (samplesheet.csv) [100%] 1 of 1 ✔
[f2/16cd28] process > NFCORE_BLOBTOOLKIT:BLOBTOOLKIT:SAMTOOLS_VIEW (mMelMel3_T2)                     [100%] 4 of 4 ✔
........
-[nf-core/blobtoolkit] Pipeline completed successfully-
WARN: There's no process matching config selector: CUSTOM_DUMPSOFTWAREVERSIONS
WARN: There's no process matching config selector: FASTQC
WARN: Singularity cache directory has not been defined -- Remote image will be stored in the path: ... -- Use env variable NXF_SINGULARITY_CACHEDIR to specify a different location
muffato commented 1 year ago

Hi. The problem actually comes from this commit: https://github.com/sanger-tol/blobtoolkit/commit/378a56f805478bf9b906075551a95cffbfe480cb . You can see that the line was sort-of moved.

Rather than removing it, can you move it back to where it was, i.e. right after CONFIG FILES ?

alxndrdiaz commented 1 year ago

Hi. The problem actually comes from this commit: 378a56f . You can see that the line was sort-of moved.

Rather than removing it, can you move it back to where it was, i.e. right after CONFIG FILES ?

Done. Used:

git checkout 378a56f -- workflows/blobtoolkit.nf

Then made the requested change and pushed the changes with git push.