Closed zb32 closed 1 year ago
- Make requested changes to pipeline.
- Test
test.config
locally with.sandbox
.- Update
test.config
to work withs3
- Test updated
test.config
- Make sure all tests pass in GitHub, if not list why in your PR. Sometimes
nf-core linting
fails because we have modified the original template, but the failures must be within reason.
All requested changes made and test.config
updated to work with S3. All tests passed apart from nf-core linting which fails because a python module is not found.
Regarding the modules folder, make sure the structure matches the repo nf-core/modules. If not delete and re-install. Also delete the modules config from your home dir and the modules json file from your pipeline directory.
Alternatively, if the pipeline runs without errors (which it seems to), move on to the other 2 modules (fasta_windows and mosdepth) and we can fix the linting errors and merge later.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).