sanger-tol / blobtoolkit

Nextflow pipeline for BlobToolKit for Sanger ToL production suite
https://pipelines.tol.sanger.ac.uk/blobtoolkit
MIT License
10 stars 0 forks source link

Pipeline update #33

Closed zb32 closed 1 year ago

zb32 commented 1 year ago

PR checklist

zb32 commented 1 year ago
  • Make requested changes to pipeline.
  • Test test.config locally with .sandbox.
  • Update test.config to work with s3
  • Test updated test.config
  • Make sure all tests pass in GitHub, if not list why in your PR. Sometimes nf-core linting fails because we have modified the original template, but the failures must be within reason.

All requested changes made and test.config updated to work with S3. All tests passed apart from nf-core linting which fails because a python module is not found.

priyanka-surana commented 1 year ago

Regarding the modules folder, make sure the structure matches the repo nf-core/modules. If not delete and re-install. Also delete the modules config from your home dir and the modules json file from your pipeline directory.

Alternatively, if the pipeline runs without errors (which it seems to), move on to the other 2 modules (fasta_windows and mosdepth) and we can fix the linting errors and merge later.