sanger-tol / blobtoolkit

Nextflow pipeline for BlobToolKit for Sanger ToL production suite
https://pipelines.tol.sanger.ac.uk/blobtoolkit
MIT License
11 stars 1 forks source link

Count busco genes #40

Closed zb32 closed 1 year ago

zb32 commented 1 year ago

count_busco_genes module

Created a module for count_busco_genes and a new subworkflow called collate_stats where the module is called. Both unit and full local tests are working.

PR checklist

zb32 commented 1 year ago

Try to get PythonBlack, Prettier and EditorConfig working. Also comment if both unit and full local tests are working.

I've got EditorConfig working now. PythonBlack is working locally but still failing the tests on Github. When I run Prettier on the parameters.md file it makes the file harder to read with some text in the table being cut off onto new rows.

muffato commented 1 year ago

I saw a comment about black failing on the nf-core Slack. It's because GitHub checks use the latest stable version of black, which was just updated a couple of weeks ago. Apparently, it's black's policy that they update their stable version once a year, in January. I'll get black updated on the farm, so that we can use it effectively

zb32 commented 1 year ago

Try to get PythonBlack, Prettier and EditorConfig working. Also comment if both unit and full local tests are working.

I've now ran both the test and test_full profiles and both work