Ci tests

[zb32]

Change PR request template and run unit tests (sangertest) when a PR is created.

PR checklist

• [x] This comment contains a description of changes (with reason).
• [x] Make sure your code lints (nf-core lint).
• [x] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).

[gq1]

          revision: ${{ github.sha }}
          workdir: ${{ secrets.TOWER_WORKDIR_PARENT }}/work/${{ github.repository }}/work-${{ github.sha }}
          parameters: |
            {
              "outdir": "${{ secrets.TOWER_WORKDIR_PARENT }}/results/${{ github.repository }}/results-${{ github.sha }}",
            }

Change github.sha to REVISION

[zb32]

Looks good. Should we disable the GitHub CI tests? But leave the linting tests on.

I've disabled the CI tests and now we can only run them manually :D

[gq1]

Can we just remove the ci.ymlcompletely? At least remove the nextflow 21.0 test, I remember some problems to run under this version. https://github.com/sanger-tol/blobtoolkit/blob/b6234f6f8093b0458377bd6bffb91f480362b6ac/.github/workflows/ci.yml#L19

[gq1]

Sanger LSF test and fulltest looks fine now.

My question is whether we really want the simple test to run for PR. The last run took 8 hours and this morning @zb32 pushed 3 times to the PR, 3 more runs bing triggered.

Can we make the test data smaller?

[muffato]

It's only taking 8 hours because of the issues on the farm. I think it can run under half-an-hour otherwise ?

[zb32]

Can we just remove the ci.ymlcompletely? At least remove the nextflow 21.0 test, I remember some problems to run under this version.

https://github.com/sanger-tol/blobtoolkit/blob/b6234f6f8093b0458377bd6bffb91f480362b6ac/.github/workflows/ci.yml#L19

I can remove line 19 from the CI test but me and @priyanka-surana decided to keep the CI test from the nf-core template but not run it

[zb32]

Sanger LSF test and fulltest looks fine now.

My question is whether we really want the simple test to run for PR. The last run took 8 hours and this morning @zb32 pushed 3 times to the PR, 3 more runs bing triggered.

Can we make the test data smaller?

I can try and push less and remember to run nf-core lint and prettier before pushing which should remove some of the runs triggered :D

[gq1]

The last 3 runs finished in 10 mins. It is good if the farm is ok.

The works dir also being cleaned for the last run but still 78M left, comparing the old ones with 1.7G.