Closed ksenia-krasheninnikova closed 10 months ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 10093d9
+| ✅ 131 tests passed |+
#| ❔ 18 tests were ignored |#
!| ❗ 14 tests had warnings |!
Removed all redundant files from the emit section. I think it can be merged in now. Thanks @priyanka-surana
I find this
emit
section confusing and difficult to navigate. Could be just me since I am not familiar with MitoHifi. Looking for a more informed view @muffato since you are familiar with the tool.
I'm not that familiar with MitoHifi :) !
I can see you cleaned up the entire emit
section. It simplifies things a lot ! For the record, I had some questions about that structure:
tuple val(meta), path(input)
rather than the mutually-exclusive reads
and contigs
$args $input
in the MitoHifi command-line rather than ${run_type}
$args
does contain either -c
or -r
(one of them is mandatory)ORGANELLES_READS
and once as ORGANELLES_ASM
Could you make the MitoHifi module take a single input like this:
- Define it as
tuple val(meta), path(input)
rather than the mutually-exclusivereads
andcontigs
- Use
$args $input
in the MitoHifi command-line rather than${run_type}
- First check that
$args
does contain either-c
or-r
(one of them is mandatory)- Then, do you need this one subworkflow to choose between the assembly and read mode and duplicate the input and output channels ? Could you imagine having a single subworkflow that is agnostic of the mode (just one input channel and one et of output channels), and in the parent workflow you would import it twice: once as
ORGANELLES_READS
and once asORGANELLES_ASM
Thank you @muffato for suggestions. I've updated the code, could you have a look if it's what you mean please? I had to put -r/-c into ext.args2 because the input file should follow the corresponding option immediately:
usage: MitoHiFi [-h] (-r <reads>.fasta | -c <contigs>.fasta) -f
<relatedMito>.fasta -g <relatedMito>.gbk -t <THREADS> [-d]
[-a {animal,plant,fungi}] [-p <PERC>] [-m <BLOOM FILTER>]
[--max-read-len MAX_READ_LEN] [--mitos]
[--circular-size CIRCULAR_SIZE]
[--circular-offset CIRCULAR_OFFSET] [-winSize WINSIZE]
[-covMap COVMAP] [-v] [-o <GENETIC CODE>]
The purpose of the original implementation of the organelles workflow was to separate the whole organelles logic into the separate workflow to lighten up the main workflow. My concern though is that the main workflow getting rather long. Is it a standard practice to keep it that way? It will become more readable when I add documentation.
@muffato Merged it updated mitohifi module from nf-core. All the review items must have been addressed for now! PR ready for the final review. Thanks!
Implements assembling mito from raw reads and from assembly
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).