sanger-tol / genomeassembly

Implementation of ToL genome assembly workflows
https://pipelines.tol.sanger.ac.uk/genomeassembly
MIT License
17 stars 2 forks source link

Added the Martian template as an asset #7

Closed muffato closed 1 year ago

muffato commented 1 year ago

This PR is to make longranger work in LSF mode in the pipeline. I haven't had any issue with my tests so far (the test profile of this pipeline). The only change I had to make was adding this template, which I guess you had uncommitted in your checkout

I'll leave this as a draft PR until we've confirmed it works for everyone

PR checklist

priyanka-surana commented 1 year ago

@muffato Try adding --jobmode=lsf to LONGRANGER_ALIGN ext.args and running it.

muffato commented 1 year ago

In an interactive session with 12 cores:

At the last dev day, I did the same on a 16-core interactive session:

which shows how variable the runtime can be.

Overall, I'm not too troubled by the difference on this test dataset. I'm reinsured that I can see the jobs filling up bjobs when run in LSF jobmode.