Closed tkchafin closed 3 months ago
Hi @SandraBabirye I have pushed some changes hopefully addressing issue https://github.com/sanger-tol/readmapping/issues/64 for the readmapping pipeline.
I thought this might be a good chance to try out doing a code review! Could you test that the pipeline works and generates the correct outputs for each combination of the new arguments:
nextflow run main.nf -profile test,docker --outfmt bam,cram --compression none
nextflow run main.nf -profile test,docker --outfmt bam,cram --compression cram
nextflow run main.nf -profile test,docker --outfmt bam
nextflow run main.nf -profile test,docker --outfmt cram
And take a look at my implementation please? There should be an "add review" button in green in the top right
Addresses https://github.com/sanger-tol/readmapping/issues/64
--outfmt
option--compression
optionPR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).