sanger-tol / readmapping

Nextflow DSL2 pipeline to align short and long reads to genome assembly. This workflow is part of the Tree of Life production suite.
https://pipelines.tol.sanger.ac.uk/readmapping
MIT License
11 stars 6 forks source link

Give user control of output format and compression #107

Closed tkchafin closed 3 months ago

tkchafin commented 3 months ago

Addresses https://github.com/sanger-tol/readmapping/issues/64

PR checklist

tkchafin commented 3 months ago

Hi @SandraBabirye I have pushed some changes hopefully addressing issue https://github.com/sanger-tol/readmapping/issues/64 for the readmapping pipeline.

I thought this might be a good chance to try out doing a code review! Could you test that the pipeline works and generates the correct outputs for each combination of the new arguments:

nextflow run main.nf -profile test,docker --outfmt bam,cram --compression none 
nextflow run main.nf -profile test,docker --outfmt bam,cram --compression cram 
nextflow run main.nf -profile test,docker --outfmt bam
nextflow run main.nf -profile test,docker --outfmt cram

And take a look at my implementation please? There should be an "add review" button in green in the top right