Closed gq1 closed 6 months ago
main
branch :x:base
to dev
Hi @gq1,
It looks like this pull-request is has been made against the sanger-tol/variantcalling main
branch.
The main
branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to main
are only allowed if they come from the sanger-tol/variantcalling dev
branch.
You do not need to close this PR, you can change the target branch to dev
by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.
Thanks again for your contribution!
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit b3dd6f9
+| ✅ 125 tests passed |+
#| ❔ 26 tests were ignored |#
!| ❗ 1 tests had warnings |!
@muffato It seems increasing the resources for CI for this pipeline didn't improve anything. It took around 5mins both before and after the change.
And also this CI is not just for testing on Github, I can use it on my laptop and farm. The laptop may not have 4 cores or 10G memory and also the requirement may be wasteful on the farm.
I know some other pipelines may have CI profile just for Github, maybe we should treat this pipeline by pipeline, not just apply the changes to all of them.
Those are very good points. Yes, it makes sense to decide this on a pipeline-per-pipeline basis
Probably I will not merge this, just close it.
This resource config is actually from nf-core template: https://github.com/sanger-tol/variantcalling/blob/TEMPLATE/conf/test.config
Does the nf-core update their template? The runner updating in 17 Jan and the latest nf-core release 2.13.1 on 29th Feb.
I will check it any changes from the template.
The latest nf-core 2.13.1 didn't change the template.
Yes, nf-core still update the template, although perhaps not every release. Maybe they don't know about the GitHub CI Runner change either.
OK to close this one
More resources are not necessary and this profile can be used not just in Github runnder.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).