#1309: Support Rails 7 syntax for Rails/EnumHash cop. (@ytjmt)
#1298: Support Rails 7 syntax for Rails/EnumUniqueness cop. (@ytjmt)
Bug fixes
#1335: Fix an error for Rails/BulkChangeTable when the block for change_table is empty. (@earlopain)
#1325: Fix an error for Rails/RenderPlainText when the content type is passed as a constant. (@earlopain)
#1337: Fix an error for Rails/Validation when passing no arguments. (@earlopain)
#1330: Fix an error for Rails/WhereNot when using placeholder without second argument. (@earlopain)
#1311: Fix false negatives for Rails/ActionControllerFlashBeforeRender when using implicit render or rescue blocks. (@tldn0718)
#1313: Fix false positives for Rails/CompactBlank when using collection.reject!. (@koic)
#1319: Fix a false positive for Rails/RedundantPresenceValidationOnBelongsTo when removing presence would leave other non-validation options like allow_blank without validations. (@earlopain)
#1306: Make Rails/PluralizationGrammar aware of byte methods. (@earlopain)
#1302: Allow params receiver by default for Style/CollectionMethods. (@koic)
#1321: Fix an error for Rails/WhereEquals when the second argument is not yet typed (where("foo = ?", )). (@earlopain)
Changes
#1308: Change Rails/CompactBlank to handle select(&:present?). (@fatkodima)
#1303: Change Rails/IgnoredSkipActionFilterOption to handle multiple callbacks. (@fatkodima)
#1199: Make Rails/WhereEquals aware of where.not(...). (@earlopain)
#1003: Change Rails/RootPathnameMethods to detect offenses on Dir.[]. (@r7kamura)
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.
All Depfu comment commands
@depfu rebase
Rebases against your default branch and redoes this update
@depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@depfu cancel merge
Cancels automatic merging of this PR
@depfu close
Closes this PR and deletes the branch
@depfu reopen
Restores the branch and reopens this PR (if it's closed)
@depfu pause
Ignores all future updates for this dependency and closes this PR
@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
stevieing
commented
1 month ago
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop-rails (2.25.1 → 2.26.1) · Repo · Changelog
Release Notes
2.26.1
2.26.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 68 commits:
Cut 2.26.1Update ChangelogMerge pull request #1357 from masato-bkn/add-tests-for-rails-compact-blankAdd missing tests for `Rails/CompactBlank` when receiver is a hashMerge pull request #1349 from fatkodima/application_record_ignore-migrationsMerge pull request #1352 from masato-bkn/fix/rails-pluralization-grammar-exampleFix example in `Rails/PluralizationGrammar`Change `Rails/ApplicationRecord` to ignore migrationsMerge pull request #1350 from fatkodima/change-enum_syntax-to-autocorrect-underscored-optionsChange `Rails/EnumSyntax` to autocorrect underscored optionsMerge pull request #1348 from Earlopain/enum-syntax-non-literal[Fix #1343] False negatives for `Rails/EnumSyntax`Merge pull request #1347 from Earlopain/offense-message-root-pathname-methods[Fix #1345] Improve offense message for `Rails/RootPathnameMethods`Merge pull request #1341 from Earlopain/where-equals-database-qualifierMerge pull request #1338 from Earlopain/enable-undefined-config[Fix #1340] Fix a false positive for `Rails/WhereEquals` when qualifying the database nameEnable `InternalAffairs/UndefinedConfig`Merge pull request #1339 from Earlopain/compatibility-codeRemove RuboCop < 1.52 compatibility codeSwitch back docs version to masterCut 2.26.0Update ChangelogMerge pull request #1337 from Earlopain/validation-errorMerge pull request #1336 from koic/add_new_rails_enum_syntax_copMerge pull request #1309 from ytjmt/support-new-enum-syntax-for-enum-hash-cop[Fix #1238] Add new `Rails/EnumSyntax` copMerge pull request #1335 from Earlopain/error-bulk-change-tableFix an error for `Rails/Validation` when passing no argumentsUpdate `Rails/Validation` specs to modern styleMerge pull request #1334 from Earlopain/cop-registry-deprecatedFix an error for `Rails/BulkChangeTable` when the block for `change_table` is emptyDon't use deprecated `Cop.registry` in specsUpdate a changelog file nameMerge pull request #1003 from r7kamura/root-pathname-methods-indexMerge pull request #1323 from Earlopain/where-equal-not[Fix #1199] Make `Rails/WhereEquals` aware of `where.not(...)`Merge pull request #1330 from Earlopain/where-not-errorFix an error for `Rails/WhereNot` without second argumentMerge pull request #1325 from Earlopain/render-plain-text-errorFix an error for `Rails/RenderPlainText` when the content type is passed as a constantMerge pull request #1321 from Earlopain/where-equal-errorFix an error for `Style/WhereEquals` when the second argument is not yet typedMerge pull request #1320 from Earlopain/rails-version-redundant-presence-validation[Fix #1319] Fix false positive for `RedundantPresenceValidationOnBelongsTo`Merge pull request #1316 from Uaitt/documentation-typoCorrect typo in Rails/WhereEquals documentationMerge pull request #1311 from tldn0718/fix-false-negatives-for-action-controller-flash-before-renderMerge pull request #1302 from koic/make_style_collection_compact_aware_of_paramsAllow `params` receiver by default for `Style/CollectionMethods`Merge pull request #1314 from biow0lf/fix-docsUse right ticksMerge pull request #1313 from koic/fix_false_positive_for_rails_compact_blankFix false positives for `Rails/CompactBlank`Merge pull request #1310 from fatkodima/compact_blank-select_presentSupport Rails 7 syntax for Rails/EnumHash copFix false negatives for implicit render or rescue blocksChange `Rails/CompactBlank` to handle `select(&:present?)`Merge pull request #1307 from padarom/fix-pluck-in-where-documentationSuppress RuboCop offensesClarify the wording of the `Rails/PluckInWhere` copMerge pull request #1298 from ytjmt/support-new-enum-syntax-for-enum-uniqueness-copSuppress RuboCop offenseMerge pull request #1306 from Earlopain/pluralization-grammar-byteMake `Rails/PluralizationGrammar` aware of byte methodsMerge pull request #1304 from fatkodima/ignored_skip_action_filter_option-multiple-callbacksChange `Rails/IgnoredSkipActionFilterOption` to handle multiple callbacksSwitch back docs version to masterDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands