Open sdjmchattie opened 4 weeks ago
Reviewing the code, there are v1 endpoints being called in a lot of places, which is not reflected in the endpoints actually being hit on Sequencescape as shown above. The working assumption is that Gate Keeper is not used as much any more and only some parts of it are in active use. To track, though, the obvious uses of v1 endpoints are for:
These may not be exhaustive, but I think they are. The stakeholders will be consulted on this as this would be a lot of work to switch over to V2 and it looks like most of this isn't actually used.
User story
Sequencescape API v1 will be shut down in the near future and has been deprecated for the past 5 years. We should switch usage of the API over to v2 by installing and making use of the
json_api_client
gem.Who are the primary contacts for this story
Stuart McHattie
Who is the nominated tester for UAT
PSD
Acceptance criteria
To be considered successful the solution must allow:
sequencescape-client-api
and its config have been removed.Dependencies Any new endpoints required in Sequencescape will have to be created as they are discovered to be missing. A new story should be created under that repository if there are indeed endpoints to create.
Additional context
The calls made during the last two week period are as below, with counts for each endpoint:
GET - /api/1/: 33
GET - /api/1/tag_layout_templates: 4
GET - /api/1/tag_layout_templates/2: 4
GET - /api/1/{uuid}: 45
GET - /api/1/{uuid}/qcables: 12
POST - /api/1/qcable_creators: 4
POST - /api/1/{uuid}/first: 17
POST - /api/1/{uuid}/lots: 4