sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
4 stars 8 forks source link

DPL-924 10X PCR binning strategies change #1397

Closed KatyTaylor closed 6 months ago

KatyTaylor commented 1 year ago

User story As a user of the scRNA Core pipeline, I would like Limber to generate a robot driver file for the "10X HT 5' Cherrypick --> 10X HT 5' cDNA Dil" transfer (exact naming to be finalised).

This should be similar to the current 10x pipeline (“LBC Cherrypick --> LBC 5p GEX Dil” transfer/ step to ‘Download Cherrypick to Sample Dilution CSV’) however the current process sets volumes to pick based on concentration and bins samples into either 12 or 14 PCR cycles. For the scRNA pipeline, the volume to pick should be set at 20ul and the range of cycles to bin into should be increased (see additional context for rules).

Who are the primary contacts for this story Lesley, Abby

Who is the nominated tester for UAT Lesley, Abby

Acceptance criteria

Driver file example for existing pipeline, showing layout: image

Dependencies Blocked by:

Additional context Table of corresponding sample concentrations and PCR cycles. We still need to determine the exact cycle numbers where a range is given. I will update you once we know. image

Image of an existing line sharing similar logic: image

ac38 commented 1 year ago

Hi Katy, For the existing line, they need to be able to support both binning routes. Eventually the original method may fall out of use (determined by which 10x kit Faculty use for their sample prep) but they will need both options available for some time. Faculty should be able to let the SSRs know which kit has been used at sample submission though and therefore which line to go down.

KatyTaylor commented 1 year ago

Thinking that it would make sense to duplicate the pipeline and add 'HT' into all the purpose names. This story would be just relevant in the 'HT' pipeline. Just the 5' pipeline --> 5' HT for now.

andrewsparkes commented 1 year ago

Wondering if we can modify the existing labware creator for binning for PCR cycles to be useable for this (possibly with additional purpose config options for the changed rules) rather than duplicate it.

KatyTaylor commented 8 months ago

If GEM X kit is used, numbers in table / volume might change but overall strategy is the same.

andrewsparkes commented 6 months ago

Integration suite test branch PR here: https://gitlab.internal.sanger.ac.uk/psd/integration-suite/-/merge_requests/128

KatyTaylor commented 5 months ago

TO DO: generate data to allow Abby to test this step.

KatyTaylor commented 5 months ago

UAT notes from Abby:

I created SQPU-85893-C from this cherrypick plate. Attached is the concentration file. What strategy is it currently using to bin the samples (pic attached)? For GEM-X I know we haven't specified the exact cycle numbers but there should only be 6 options total. Is it helpful to set a number for now and then change it later? For the 'hamilton_lrc_ht_5p_cherrypick_to_lrc_ht_5p_gex_dil' driver file, the sample vol should be set to '10' for GEM-X (and same thing with name changes to replace 'HT'.

Concentration file used for above UAT - concentrations_ngul (3).csv

Screenshot from above UAT: image (2)

Note from Katy:

KatyTaylor commented 5 months ago

Moving this to done as Abby is happy with it. PR mentioned in above comment is merged and tested. The PCR cycle numbers in the config will probably need to be changed once R&D have figured out what numbers they'd like - Abby to let us know when that change is needed.