sanger / limber

A flexible lims extension of the old app
MIT License
3 stars 8 forks source link

Y24-023 [BUG] Reconcile handling of default states #1619

Open StephenHulme opened 4 months ago

StephenHulme commented 4 months ago

Describe the bug

The default states of some labware is handled inconsitently within Limber itself.

This is partly due to the RVI Cherrypick purpose being able to cherry pick to itself, but is indicative of a lack of central handling of state defaults.

RT Ticket Number

None PR - #1594

To Reproduce

Steps to reproduce the behaviour:

  1. Go to the RVI Pipeline Progress page
  2. Note that Labware SQPU-55837-C in RVI Cherrypick is stated as pending
  3. Click the link on the labware
  4. Note that the labware page indicates the status as passed

Expected behaviour

Both of these states should be the same (probably passed)

Screenshots

Screenshot 2024-03-11 at 11 46 13 Screenshot 2024-03-11 at 11 45 49

Additional context

See the progress controller for one potential cause of this inconsistency

First noticed in #1596