sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
3 stars 8 forks source link

DPL-1024-2 PBMC donor pooling - ancestor plates #1625

Closed yoldas closed 6 months ago

yoldas commented 6 months ago

Closes #

Changes proposed in this pull request

Updates for using multiple ancestor plates in driver file download

Summary:

The ancestor_purpose setting of an export configuration will make an additional controller instance variable@ancestor_plate_list populated with all ancestor plates of that purpose and available in the view template.

Background:

The existing export controller allows making an ancestor plate available to the export view template by specifying the ancestor plate purpose in the export configuration. This is useful in several cases, for example, access to parent plate barcode and relating source wells specified in transfer templates in driver file exports. However, only one ancestor plate is made available to the view, the first, which assumes a single parent for the current plate being viewed and download requested.

In cases where a plate has (or may have) multiple ancestors of a specific purpose, such as pooling from multiple source plates, as in scRNA donor pooling, we need access to more than one parent in the view to interpret the transfer request and generate a column with parent barcode. This PR enables that.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.82%. Comparing base (ab16182) to head (ed329eb). Report is 8 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1625 +/- ## =========================================== + Coverage 90.80% 90.82% +0.01% =========================================== Files 359 359 Lines 7418 7423 +5 =========================================== + Hits 6736 6742 +6 + Misses 682 681 -1 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1625/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1625/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.64% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1625/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.82% <100.00%> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1625/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.82% <100.00%> (+0.01%)` | :arrow_up: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1625/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.42% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KatyTaylor commented 6 months ago

Could you add a bit more to the PR description, explaining what the problem was that you're fixing? Thanks

codeclimate[bot] commented 6 months ago

Code Climate has analyzed commit ed329ebc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.4% (0.1% change).

View more on Code Climate.

yoldas commented 6 months ago

Could you add a bit more to the PR description, explaining what the problem was that you're fixing? Thanks

I have updated the PR description to explain the problem being fixed.