sanger / limber

A flexible lims extension of the old app
MIT License
3 stars 8 forks source link

DPL-1099 Added double label for bioscan lysate plate #1635

Closed andrewsparkes closed 3 months ago

andrewsparkes commented 4 months ago

Closes #4019

Adds a second label for the Bioscan lysate plate which has the supplier partner plate id barcode on it that was stored in the sample metadata in sample_description.

Needs physical testing onsite.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.82%. Comparing base (c9e640a) to head (d75b91c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1635 +/- ## =========================================== + Coverage 90.79% 90.82% +0.02% =========================================== Files 362 363 +1 Lines 7467 7490 +23 =========================================== + Hits 6780 6803 +23 Misses 687 687 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1635/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.82% <100.00%> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.81% <100.00%> (+0.01%)` | :arrow_up: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.42% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 3 months ago

Code Climate has analyzed commit d75b91c1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.4% (0.1% change).

View more on Code Climate.