sanger / limber

A flexible lims extension of the old app
MIT License
3 stars 8 forks source link

Y24-029 Bug fix for invisible wells issue in tagging screen #1637

Closed andrewsparkes closed 4 months ago

andrewsparkes commented 4 months ago

Closes #1631

Fix for bug in tagging screen where wells are invisible

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.82%. Comparing base (c2e48bb) to head (b44a3e7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1637 +/- ## ======================================== Coverage 90.82% 90.82% ======================================== Files 359 359 Lines 7423 7423 ======================================== Hits 6742 6742 Misses 681 681 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1637/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1637/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.64% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1637/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.82% <ø> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1637/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.82% <ø> (ø)` | | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1637/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.42% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 4 months ago

Code Climate has analyzed commit b44a3e70 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.4% (0.0% change).

View more on Code Climate.

StephenHulme commented 4 months ago

Just to note that the required colour_index could cause a visible failure - but at least this should be reported this time.