sanger / limber

A flexible lims extension of the old app
MIT License
3 stars 8 forks source link

DPL-1047-18: Upgrade Node to v18 (as a stepping stone) #1645

Open StephenHulme opened 3 months ago

StephenHulme commented 3 months ago

Moves closer to closing #1541, as upgrading to v20 is non-trivial (see #1555)

Changes proposed in this pull request

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.35%. Comparing base (c5f3831) to head (4e41542). Report is 4 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1645 +/- ## ======================================== Coverage 91.35% 91.35% ======================================== Files 373 373 Lines 7657 7657 ======================================== Hits 6995 6995 Misses 662 662 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <100.00%> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.35% <100.00%> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.35% <100.00%> (ø)` | | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.03% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 1 week ago

Code Climate has analyzed commit 4e41542b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.0% (0.0% change).

View more on Code Climate.

StephenHulme commented 1 week ago

Version 16 checklist:

StephenHulme commented 1 week ago

Version 18 checklist: