search

sanger / limber

A flexible lims extension of the old app
MIT License
3 stars 8 forks source link

scRNA UAT fix - added EMPTY to options for missing tubes #1666

Closed andrewsparkes closed 3 months ago

andrewsparkes commented 3 months ago

Added EMPTY to the list of possible values indicating an empty position in a tube rack scan file

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.84%. Comparing base (6c81da0) to head (78d16e1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1666 +/- ## ======================================== Coverage 90.84% 90.84% ======================================== Files 363 363 Lines 7511 7511 ======================================== Hits 6823 6823 Misses 688 688 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1666/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1666/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1666/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.84% <100.00%> (ø)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1666/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.84% <100.00%> (ø)` | | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1666/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.44% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 3 months ago

Code Climate has analyzed commit 78d16e1a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.4% (0.0% change).

View more on Code Climate.

KatyTaylor commented 3 months ago

Am I right in saying that this also ticks off this story - https://github.com/sanger/limber/issues/1529 ?

It's the same requirement, but for the rack scan earlier in the pipeline.