sanger / limber

A flexible lims extension of the old app
MIT License
3 stars 8 forks source link

Y24-074 scRNA - pooling tab removed and samples tab enhanced #1694

Closed andrewsparkes closed 1 month ago

andrewsparkes commented 1 month ago

Closes #1679

Changes proposed in this pull request

Adds new Presenter variant which:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.18%. Comparing base (24e3272) to head (a9bd1c8).

:exclamation: Current head a9bd1c8 differs from pull request most recent head 8a29e8c

Please upload reports for the commit 8a29e8c to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1694 +/- ## =========================================== - Coverage 91.20% 91.18% -0.03% =========================================== Files 364 363 -1 Lines 7538 7520 -18 =========================================== - Hits 6875 6857 -18 Misses 663 663 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1694/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1694/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1694/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `?` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1694/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.18% <100.00%> (-0.03%)` | :arrow_down: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1694/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.83% <100.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit a9bd1c8f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.8% (0.0% change).

View more on Code Climate.