search

sanger / limber

A flexible lims extension of the old app
MIT License
3 stars 8 forks source link

Y24-101 Tube Rack Banking Transfer Requests #1698

Open yoldas opened 1 month ago

yoldas commented 1 month ago

User story As PSD, we would like to support creation of transfer requests from Limber upon upload of tube rack scan files using the versioned tube rack model proposed in Reuse of TubeRacks document.

Who are the primary contacts for this story Abdullah, Katy, Andrew

Who is the nominated tester for UAT TBD

Acceptance criteria To be considered successful the solution must allow:

Dependencies This story is blocked by the following dependencies:

References This story has a non-blocking relationship with:

Additional context The versioned tube rack model is researched in DPL-1011 Re-use of tube racks and the model is summarised in the Google Document DPL-1011 Re-use of tube racks

This story is part of re-implementation of DPL-811 Transfer PBMC isolations into FluidX tube racks (Banking) using the versioned tube rack model.

Story relationships are shown in the Lucidchart diagram TubeRack Stories .

A TubeRack looks like the following in Sequencescape: https://sequencescape.psd.sanger.ac.uk/labware/27083543

It is not possible to release the implementation of this story in isolation.

TWJW-SANGER commented 1 month ago

I might suggest that the acceptance criteria is better phrased from the users point of view (if only for testing), so something like: The user can see the link between source and destination tube on pages X,Y,Z And maybe The user can see the link between source and destination tube racks on pages X,Y,Z

Linking the objects/tables is needed but is not sufficient to meet the criteria above (as you may need UI / API changes too...)

KatyTaylor commented 1 month ago

Agree with Tom that I generally prefer acceptance criteria from the user POV if poss. In this case though, I think the user-facing bit of transfer requests will be that the wells appear to be filled in / the plate state changes when the transfer requests are passed...

The parent child links seen in Sequencescape (and the children tab in Limber) are using a different model... asset links I think?

yoldas commented 1 month ago

I have changed the criteria to focus on the relationships between the LRC PBMC Bank Plate and LRC Bank Seq and LRC Bank Spare TubeRacks, and wells and tubes. These relationships should be visible in Sequencescape if transfer requests are created correctly. In Limber, I have included only the LRC PBMC Bank Children tab for this story. I have also added a TubeRack page as an example in Sequencescape.

I have also added https://github.com/sanger/limber/issues/1697 as dependency. The stories have some logical order, therefore it sets up transitive dependencies for this story.