search

sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
3 stars 8 forks source link

Y24-035 tnanoseq update configs for pipeline #1711

Closed andrewsparkes closed 2 months ago

andrewsparkes commented 4 months ago

Closes #1646

Changes proposed in this pull request

Updates config to allow Targeted NanoSeq to use ReISC and to loop with submissions.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.43%. Comparing base (d347ec1) to head (eaac64f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1711 +/- ## =========================================== + Coverage 91.38% 91.43% +0.04% =========================================== Files 373 373 Lines 7686 7714 +28 =========================================== + Hits 7024 7053 +29 + Misses 662 661 -1 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1711/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1711/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1711/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.43% <100.00%> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1711/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.43% <100.00%> (+0.04%)` | :arrow_up: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1711/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.12% <100.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 3 months ago

Code Climate has analyzed commit eaac64f6 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.