sanger / limber

A flexible lims extension of the old app
MIT License
3 stars 8 forks source link

1392 dpl 919 transfer pbmc pools to 10x chip #1718

Closed yoldas closed 3 weeks ago

yoldas commented 1 month ago

Closes #

Changes proposed in this pull request

Note: Check the asset_shape_id and size fields of the purpose with the name LRC GEM-X 5p Chip in the plate_purposes table of the Sequencescape database. The asset_shape_id should be the id of the record in asset_shapes with name ChromiumX and the size should be 8.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.24%. Comparing base (6e96aeb) to head (c5fc595). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1718 +/- ## =========================================== + Coverage 91.21% 91.24% +0.03% =========================================== Files 364 367 +3 Lines 7543 7572 +29 =========================================== + Hits 6880 6909 +29 Misses 663 663 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1718/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.24% <100.00%> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.24% <100.00%> (+0.03%)` | :arrow_up: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.90% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 3 weeks ago

Code Climate has analyzed commit c5fc5950 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.9% (0.1% change).

View more on Code Climate.