search

sanger / limber

A flexible lims extension of the old app
MIT License
3 stars 8 forks source link

BUG fix - changed syntax to remove fetch #1745

Closed andrewsparkes closed 1 week ago

andrewsparkes commented 1 week ago

Fixes Limber presenter bug

codeclimate[bot] commented 1 week ago

Code Climate has analyzed commit e2ba7eef and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.9% (0.0% change).

View more on Code Climate.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.27%. Comparing base (4ae20e2) to head (e2ba7ee).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1745 +/- ## ======================================== Coverage 91.27% 91.27% ======================================== Files 370 370 Lines 7584 7584 ======================================== Hits 6922 6922 Misses 662 662 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1745/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1745/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1745/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <ø> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1745/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.27% <100.00%> (ø)` | | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1745/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.93% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.