search

sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
3 stars 8 forks source link

Y24-084: Validate source tube is in rack scan file (Cryostor plate) #1746

Closed StephenHulme closed 3 months ago

StephenHulme commented 3 months ago

Closes #1689

Changes proposed in this pull request

For the LRC Bank Seq tube SQ25131701

This file passes

TR12345678,A1,SQ25131702
TR12345678,B1,SP25131707
TR12345678,C1,SQ25131701 <-- source tube

This file fails

TR12345678,A1,SQ25131702
TR12345678,B1,SP25131707
TR12345678,C1,SQ25131703 <-- NO source tube

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.38%. Comparing base (cfe817e) to head (39c9ab5). Report is 8 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1746 +/- ## =========================================== + Coverage 91.35% 91.38% +0.02% =========================================== Files 372 372 Lines 7660 7681 +21 =========================================== + Hits 6998 7019 +21 Misses 662 662 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1746/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1746/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1746/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.37% <100.00%> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1746/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.37% <100.00%> (+0.01%)` | :arrow_up: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1746/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.06% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KatyTaylor commented 3 months ago

Approved but just noticed you've got a failing test

StephenHulme commented 3 months ago

Approved but just noticed you've got a failing test

It's the date one that got @BenTopping yesterday. I'll update from develop.

codeclimate[bot] commented 3 months ago

Code Climate has analyzed commit 39c9ab53 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.0% (0.0% change).

View more on Code Climate.

StephenHulme commented 3 months ago

Approved but just noticed you've got a failing test

Thanks @KatyTaylor fixed now :D