sanger / limber

A flexible lims extension of the old app
MIT License
3 stars 8 forks source link

DPL-1031 - File name improvements #1752

Closed BenTopping closed 1 day ago

BenTopping commented 1 week ago

Closes #1521

Changes proposed in this pull request

Instructions for Reviewers

There are no independent unit tests, mainly because the exports_controller tests it by proxy and it is has a different style of testing. But I have tested manually with a few variations and it is working.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.36%. Comparing base (cfe817e) to head (f3c55a7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1752 +/- ## =========================================== + Coverage 91.35% 91.36% +0.01% =========================================== Files 372 373 +1 Lines 7660 7669 +9 =========================================== + Hits 6998 7007 +9 Misses 662 662 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1752/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1752/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1752/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.36% <100.00%> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1752/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.36% <100.00%> (+0.01%)` | :arrow_up: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1752/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.05% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 2 days ago

Code Climate has analyzed commit f3c55a73 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.0% (0.0% change).

View more on Code Climate.