sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
3 stars 8 forks source link

Test fix cellaca plate label date test #1756

Closed BenTopping closed 3 months ago

BenTopping commented 3 months ago

This change is causing CI issues currently. See: https://github.com/sanger/limber/actions/runs/9744623445/job/26890652637

Changes proposed in this pull request

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.35%. Comparing base (bbc35a5) to head (3d3a66a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1756 +/- ## ======================================== Coverage 91.35% 91.35% ======================================== Files 372 372 Lines 7660 7660 ======================================== Hits 6998 6998 Misses 662 662 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1756/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1756/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1756/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.35% <ø> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1756/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.35% <ø> (ø)` | | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1756/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.04% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BenTopping commented 3 months ago

@StephenHulme My theory is this check only fails from the 1st -9th as its the leading zero thats causing the problems. From a quick look this test hasn't been in long so it could be it has never run from the 1st-9th before. I think this is because the test date match is wrong, where it should be using the same format as here. I ripped the regex from another label test but looking at some of the other tests perhaps using this date time structure would be the better fix ...

codeclimate[bot] commented 3 months ago

Code Climate has analyzed commit 3d3a66a4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.0% (0.0% change).

View more on Code Climate.