sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
3 stars 8 forks source link

Y24-178 - Modify scRNA cDNA prep request types #1802

Closed BenTopping closed 2 months ago

BenTopping commented 2 months ago

Closes #1768

Changes proposed in this pull request

Instructions for Reviewers

Requires: https://github.com/sanger/sequencescape/pull/4222 Integration suite branch: y24-178-modify-cdna-prep-submission

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.35%. Comparing base (9745649) to head (b6834d3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1802 +/- ## ======================================== Coverage 91.35% 91.35% ======================================== Files 373 373 Lines 7657 7657 ======================================== Hits 6995 6995 Misses 662 662 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1802/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1802/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1802/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.35% <ø> (ø)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1802/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.35% <ø> (ø)` | | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1802/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.03% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 2 months ago

Code Climate has analyzed commit b6834d3a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.0% (0.0% change).

View more on Code Climate.

BenTopping commented 2 months ago

Just checking you are aware the limber_scrna_core_cdna_prep_v2 type is defined in SS and used in a submission template (2 record loader files), so is that being updated too? Didn't see a related SS PR on the story.

Thanks, yeah I have linked the SS PR in this PR description. Ill also link it to the story 👍