sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
3 stars 8 forks source link

DPL-1047-16: Upgrade Node to v16 #1804

Closed StephenHulme closed 2 months ago

StephenHulme commented 2 months ago

Moves closer to closing https://github.com/sanger/limber/issues/1541, as upgrading to v20 is non-trivial (see https://github.com/sanger/limber/pull/1555) Preceeds #1645

Changes proposed in this pull request

Version 16 checklist:

Deployment Instructions

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.40%. Comparing base (baf1b58) to head (3fe50ed).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1804 +/- ## ======================================== Coverage 91.40% 91.40% ======================================== Files 376 376 Lines 7656 7656 ======================================== Hits 6998 6998 Misses 658 658 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1804/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1804/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.65% <100.00%> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1804/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.40% <100.00%> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1804/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.40% <100.00%> (ø)` | | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1804/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.09% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 2 months ago

Code Climate has analyzed commit 5175a78b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.