Closed StephenHulme closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.40%. Comparing base (
2934db3
) to head (475d6da
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It's working 🙂 Note the edit history:
after_n_builds
was set to 2js_test (push)
, js_test (pull_request)
ruby_test (push)
, ruby_test (pull_request)
after_n_builds
to 4:Looks sensible. What happens if an action is cancelled or a test suite fails, does that still count as a 'build'?
I think 'build' in this context is any uploaded coverage report. In this case, I imagine that no report will be generated - which is probably sensible since it doesn't have sufficient data. A more active failure mode might be preferable, but I think this is a reasonable tradeoff for the increased accuracy.
Code Climate has analyzed commit 475d6da0 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 91.0% (0.0% change).
View more on Code Climate.
JS tests finish before Ruby tests, meaning CodeCov publishes it's report before all information has been recieved.
Changes proposed in this pull request
Related to
DPL-1034: Combine code coverage from both Javascript and Ruby code
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version