search

sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
3 stars 8 forks source link

Master back into develop after Targeted NanoSeq release #1810

Closed andrewsparkes closed 2 months ago

andrewsparkes commented 2 months ago

To ensure develop has all the changes made in master.

codeclimate[bot] commented 2 months ago

Code Climate has analyzed commit aead7718 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.0% (0.0% change).

View more on Code Climate.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.06%. Comparing base (4bf43dc) to head (aead771). Report is 28 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1810 +/- ## =========================================== - Coverage 91.35% 91.06% -0.29% =========================================== Files 373 376 +3 Lines 7657 7760 +103 =========================================== + Hits 6995 7067 +72 - Misses 662 693 +31 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1810/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1810/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `93.72% <ø> (+0.06%)` | :arrow_up: | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1810/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.45% <100.00%> (+0.11%)` | :arrow_up: | | [push](https://app.codecov.io/gh/sanger/limber/pull/1810/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.39% <100.00%> (+0.04%)` | :arrow_up: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1810/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `90.70% <100.00%> (-0.34%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.