Y24-294 - [BUG] [Flaxy Test] No wells with aliquots found in this labware to fetch a sample

StephenHulme commented 1 month ago

Email subject line

[Psd-exceptions] [Limber STAGING] plates#show (ActionView::Template::Error) "No wells with aliquots found in this labware to fetch a samp...

Error body

An ActionView::Template::Error occurred in plates#show:

  No wells with aliquots found in this labware to fetch a sample
  app/models/labels/plate_label_96_lysate.rb:76:in `sample_from_first_populated_well'

Acceptance Criteria

[ ] Look into this exception and fix the code to handle the exception sensibly.
[ ] Document the root cause and solution in a comment on this issue.

[ ] Confirm Integration Suite tests pass


for i in $(seq 1 10); do (DEBUG_ON_FAIL=true ENVIRONMENT=uat bundle exec rspec ./spec/limber/bioscan_pipelines_spec.rb:131 > $i.test_log  &); done```

Additional information

This is causing Integration Suite test ./spec/limber/bioscan_pipelines_spec.rb:131 to occasionally fail, reducing trust in the test suite. The id of the user who triggered this error is often shown in the exception email, in case you need to communicate with them.

andrewsparkes commented 3 weeks ago

I wonder if that's just a timing issue, it hasn't finished actioning the transfers into the Lysate plate when it tries to query the well? Alternatively, the method isn't correctly checking just 'populated' wells and is looking in an empty one for an aliquot?

stevieing commented 2 weeks ago

Integration suite error. Happens 1 in 10 runs of the integration suite.

Could be just a fix to the test?

sanger / limber