sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
3 stars 8 forks source link

Y24-314: Only show relatives if they have a purpose #1928

Closed StephenHulme closed 2 weeks ago

StephenHulme commented 2 weeks ago

Closes #1910

Changes proposed in this pull request

Screenshot 2024-09-17 at 12 06 59

Instructions for Reviewers

Compare to #1920

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

codeclimate[bot] commented 2 weeks ago

Code Climate has analyzed commit 2373a24c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.46%. Comparing base (e9f41ba) to head (2373a24). Report is 4 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1928 +/- ## ======================================== Coverage 77.46% 77.46% ======================================== Files 455 455 Lines 17275 17275 Branches 229 229 ======================================== Hits 13382 13382 Misses 3891 3891 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1928/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `68.61% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `77.46% <ø> (ø)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/1928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `77.46% <ø> (ø)` | | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.13% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.