sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
3 stars 8 forks source link

Y24-319 - scRNA Pooling driver file changes #1936

Closed BenTopping closed 1 week ago

BenTopping commented 2 weeks ago

Closes #1914

Changes proposed in this pull request

Requires branch: https://github.com/sanger/sequencescape/pull/4357

Additional notes

I have made changes to qc threshold view so we don't show unwanted qc results like live_cell_count. The preferred solution would be to leave this as in and not create the live_cell_count qc results in the first place but that means we would need to change the sequencescape file parser to be separate for cardinal and scrna. This would not be a quick fix as the parser is determined by the file headers and both have the same headers. Earlier sections of this pipeline also use live_cell_count still.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.95%. Comparing base (2cafcb4) to head (730224f). Report is 6 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1936 +/- ## ======================================== Coverage 77.95% 77.95% ======================================== Files 460 460 Lines 17702 17702 Branches 225 225 ======================================== Hits 13800 13800 Misses 3900 3900 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1936/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `69.69% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `77.95% <100.00%> (+<0.01%)` | :arrow_up: | | [push](https://app.codecov.io/gh/sanger/limber/pull/1936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `77.95% <100.00%> (ø)` | | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.11% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 1 week ago

Code Climate has analyzed commit 730224fa and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.