Closed BenTopping closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.95%. Comparing base (
2cafcb4
) to head (730224f
). Report is 6 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Code Climate has analyzed commit 730224fa and detected 1 issue on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Complexity | 1 |
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 91.1% (0.0% change).
View more on Code Climate.
Closes #1914
Changes proposed in this pull request
Requires branch: https://github.com/sanger/sequencescape/pull/4357
Additional notes
I have made changes to qc threshold view so we don't show unwanted qc results like live_cell_count. The preferred solution would be to leave this as in and not create the live_cell_count qc results in the first place but that means we would need to change the sequencescape file parser to be separate for cardinal and scrna. This would not be a quick fix as the parser is determined by the file headers and both have the same headers. Earlier sections of this pipeline also use live_cell_count still.