sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
3 stars 8 forks source link

Adjust ongoing plates and tubes spacing #1937

Closed StephenHulme closed 1 week ago

StephenHulme commented 2 weeks ago

I keep coming to these pages to find specfic purposes for debugging and getting lost in the jumbled list...

Changes proposed in this pull request

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

StephenHulme commented 2 weeks ago

I've removed the sorting aspect, so now it just makes the purposes box bigger and fixes surrounding margins. I hope this is a suitable compromise?

codeclimate[bot] commented 2 weeks ago

Code Climate has analyzed commit 8ad2961d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.10%. Comparing base (3ef9d12) to head (8ad2961). Report is 120 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1937 +/- ## =========================================== + Coverage 77.46% 78.10% +0.63% =========================================== Files 455 459 +4 Lines 17275 17869 +594 Branches 229 229 =========================================== + Hits 13382 13956 +574 - Misses 3891 3911 +20 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/1937/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/1937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `69.69% <ø> (+1.07%)` | :arrow_up: | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/1937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `77.95% <ø> (+0.48%)` | :arrow_up: | | [push](https://app.codecov.io/gh/sanger/limber/pull/1937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `77.46% <ø> (+<0.01%)` | :arrow_up: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/1937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.16% <ø> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

StephenHulme commented 1 week ago

I've removed the sorting aspect, so now it just makes the purposes box bigger and fixes surrounding margins. I hope this is a suitable compromise?

@andrewsparkes @sdjmchattie ?