Closed StephenHulme closed 1 month ago
Attention: Patch coverage is 0%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 77.95%. Comparing base (
40ef006
) to head (60b4bba
). Report is 3 commits behind head on develop.
Files with missing lines | Patch % | Lines |
---|---|---|
app/frontend/javascript/legacy_scripts_a.js | 0.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Stalled as this should ideally be tested against the real-life scenario before merging in - maybe it can be deployed to training?
Code Climate has analyzed commit 60b4bba2 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 91.1% (0.0% change).
View more on Code Climate.
Tested successfully in training comparing against uat.
Allow pools to not be defined without breaking all javascript in the page: user errors should not cause syntax errors.
Changes proposed in this pull request
undefined
or empty-stringInstructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version